fix issue with activity entry view

apps/activity/views.py

@@ -329,7 +329,7 @@ class ActivityEntryView(LoginRequiredMixin, SingleTableMixin, TemplateView):
         context["noteuser_ctype"] = ContentType.objects.get_for_model(NoteUser).pk
         context["notespecial_ctype"] = ContentType.objects.get_for_model(NoteSpecial).pk
 
-        activities_open = Activity.objects.filter(open=True).filter(
+        activities_open = Activity.objects.filter(open=True, activity_type__manage_entries=True).filter(
             PermissionBackend.filter_queryset(self.request, Activity, "view")).distinct().all()
         context["activities_open"] = [a for a in activities_open
                                       if PermissionBackend.check_perm(self.request,

apps/member/views.py

@@ -26,7 +26,6 @@ from note_kfet.middlewares import _set_current_request
 from permission.backends import PermissionBackend
 from permission.models import Role
 from permission.views import ProtectQuerysetMixin, ProtectedCreateView
-from django import forms
 
 from .forms import UserForm, ProfileForm, ImageForm, ClubForm, MembershipForm, \
     CustomAuthenticationForm, MembershipRolesForm
@@ -73,19 +72,11 @@ class UserUpdateView(ProtectQuerysetMixin, LoginRequiredMixin, UpdateView):
         form.fields['email'].required = True
         form.fields['email'].help_text = _("This address must be valid.")
 
-        profile_form = self.profile_form(instance=context['user_object'].profile,
+        if PermissionBackend.check_perm(self.request, "member.change_profile", context['user_object'].profile):
-                                         data=self.request.POST if self.request.POST else None)
+            context['profile_form'] = self.profile_form(instance=context['user_object'].profile,
-        if not self.object.profile.report_frequency:
+                                                        data=self.request.POST if self.request.POST else None)
-            del profile_form.fields["last_report"]
+            if not self.object.profile.report_frequency:
-
+                del context['profile_form'].fields["last_report"]
-        fields_to_check = list(profile_form.fields.keys())
-
-        # Delete the fields for which the user does not have the permission to modify
-        for field_name in fields_to_check:
-            if not PermissionBackend.check_perm(self.request, f"member.change_profile_{field_name}", context['user_object'].profile):
-                profile_form.fields[field_name].widget = forms.HiddenInput()
-
-        context['profile_form'] = profile_form
 
         return context
 

apps/permission/fixtures/initial.json

@@ -3832,74 +3832,6 @@
             "description": "Voir les profils des membres du club"
         }
     },
-    {
-        "model": "permission.permission",
-        "pk": 244,
-        "fields": {
-            "model": [
-                "member",
-                "profile"
-            ],
-            "query": "{}",
-            "type": "change",
-            "mask": 3,
-            "field": "ml_events_registration",
-            "permanent": false,
-            "description": "Modifier l'abonnement à la Newsletter BDE pour n'importe quel profil"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 245,
-        "fields": {
-            "model": [
-                "member",
-                "profile"
-            ],
-            "query": "{}",
-            "type": "change",
-            "mask": 3,
-            "field": "ml_art_registration",
-            "permanent": false,
-            "description": "Modifier l'abonnement à la Newsletter Art pour n'importe quel profil"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 246,
-        "fields": {
-            "model": [
-                "member",
-                "profile"
-            ],
-            "query": "{}",
-            "type": "change",
-            "mask": 3,
-            "field": "ml_sport_registration",
-            "permanent": false,
-            "description": "Modifier l'abonnement à la Newsletter Sport pour n'importe quel profil"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 247,
-        "fields": {
-            "model": [
-                "member",
-                "profile"
-            ],
-            "query": "{}",
-            "type": "view",
-            "mask": 3,
-            "field": [
-                "ml_events_registration",
-                "ml_art_registration",
-                "ml_sport_registration"
-            ],
-            "permanent": false,
-            "description": "Voir les abonnements aux Newsletters de n'importe quel profil"
-        }
-    },
     {
         "model": "permission.role",
         "pk": 1,