From c25f6ca2c109be5201eb513a8122e4bc9bcd7b28 Mon Sep 17 00:00:00 2001 From: Ehouarn Date: Thu, 14 Aug 2025 00:34:39 +0200 Subject: [PATCH] Corrected test --- apps/family/api/views.py | 2 +- apps/family/tests/test_family.py | 12 +++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/apps/family/api/views.py b/apps/family/api/views.py index b680e135..603a98ca 100644 --- a/apps/family/api/views.py +++ b/apps/family/api/views.py @@ -89,7 +89,7 @@ class BatchAchievementsAPIView(APIView): results.append({ 'family': family.name, 'challenge': challenge.name, - 'status': 'error', + 'status': 'existed', }) for family in families: family.update_score() diff --git a/apps/family/tests/test_family.py b/apps/family/tests/test_family.py index f2b31784..1dea7937 100644 --- a/apps/family/tests/test_family.py +++ b/apps/family/tests/test_family.py @@ -239,6 +239,12 @@ class TestBatchAchievements(APITestCase): Challenge.objects.create(name=f'Challenge {i}', description='', points=50) for i in range(3) ] + self.achievement = Achievement.objects.create( + family=self.families[0], + challenge=self.challenges[0], + valid=False, + ) + self.url = reverse("family:api:batch_achievements") def test_batch_achievement_creation(self): @@ -254,7 +260,11 @@ class TestBatchAchievements(APITestCase): ) self.assertEqual(response.status_code, 201) - self.assertEqual(response.data['status'], 'ok') + for result in response.data['results']: + if result['family'] == self.families[0].name and result['challenge'] == self.challenges[0].name: + self.assertEqual(result['status'], 'existed') + else: + self.assertEqual(result['status'], 'created') expected_count = len(family_ids) * len(challenge_ids) self.assertEqual(Achievement.objects.count(), expected_count)