Add transaction type field

apps/note/models/transactions.py

@@ -107,7 +107,24 @@ class Transaction(PolymorphicModel):
         verbose_name=_('quantity'),
         default=1,
     )
-    amount = models.PositiveIntegerField(verbose_name=_('amount'), )
+    amount = models.PositiveIntegerField(
+        verbose_name=_('amount'),
+    )
+
+    type = models.CharField(
+        verbose_name=_('type'),
+        choices=(
+            ('gift', _('Gift')),
+            ('transfer', _('Transfer')),
+            ('template', _('Template')),
+            ('credit', _('Credit')),
+            ('debit', _('Debit')),
+            ('membership', _('membership transaction')),
+        ),
+        default='transfer',
+        max_length=10,
+    )
+
     reason = models.CharField(
         verbose_name=_('reason'),
         max_length=255,
@@ -158,10 +175,6 @@ class Transaction(PolymorphicModel):
     def total(self):
         return self.amount * self.quantity
 
-    @property
-    def type(self):
-        return _('transfer')
-
 
 class TemplateTransaction(Transaction):
     """
@@ -178,10 +191,6 @@ class TemplateTransaction(Transaction):
         on_delete=models.PROTECT,
     )
 
-    @property
-    def type(self):
-        return _('template')
-
 
 class SpecialTransaction(Transaction):
     """
@@ -200,7 +209,8 @@ class SpecialTransaction(Transaction):
 
     bank = models.CharField(
         max_length=255,
-        verbose_name=_("bank")
+        verbose_name=_("bank"),
+        blank=True,
     )
 
 
@@ -219,7 +229,3 @@ class MembershipTransaction(Transaction):
     class Meta:
         verbose_name = _("membership transaction")
         verbose_name_plural = _("membership transactions")
-
-    @property
-    def type(self):
-        return _('membership')

apps/note/tables.py

@@ -6,6 +6,7 @@ import html
 import django_tables2 as tables
 from django.db.models import F
 from django_tables2.utils import A
+from django.utils.translation import gettext_lazy as _
 
 from .models.notes import Alias
 from .models.transactions import Transaction
@@ -21,9 +22,11 @@ class HistoryTable(tables.Table):
         model = Transaction
         exclude = ("id", "polymorphic_ctype", )
         template_name = 'django_tables2/bootstrap4.html'
-        sequence = ('...', 'total', 'valid', )
+        sequence = ('...', 'type', 'total', 'valid', )
         orderable = False
 
+    type = tables.Column()
+
     total = tables.Column()  # will use Transaction.total() !!
 
     valid = tables.Column(attrs={"td": {"id": lambda record: "validate_" + str(record.id),
@@ -43,6 +46,9 @@ class HistoryTable(tables.Table):
     def render_total(self, value):
         return pretty_money(value)
 
+    def render_type(self, value):
+        return _(value)
+
     # Django-tables escape strings. That's a wrong thing.
     def render_reason(self, value):
         return html.unescape(value)

apps/note/views.py

@@ -6,7 +6,7 @@ from django.contrib.auth.mixins import LoginRequiredMixin
 from django.contrib.contenttypes.models import ContentType
 from django.db.models import Q
 from django.utils.translation import gettext_lazy as _
-from django.views.generic import CreateView, ListView, UpdateView, TemplateView
+from django.views.generic import CreateView, ListView, UpdateView
 from django_tables2 import SingleTableView
 
 from .forms import TransactionTemplateForm
@@ -15,14 +15,19 @@ from .models.transactions import SpecialTransaction
 from .tables import HistoryTable
 
 
-class TransactionCreate(LoginRequiredMixin, TemplateView):
+class TransactionCreate(LoginRequiredMixin, SingleTableView):
     """
     Show transfer page
 
     TODO: If user have sufficient rights, they can transfer from an other note
     """
+    queryset = Transaction.objects.order_by("-id").all()[:50]
     template_name = "note/transaction_form.html"
 
+    # Transaction history table
+    table_class = HistoryTable
+    table_pagination = {"per_page": 50}
+
     def get_context_data(self, **kwargs):
         """
         Add some context variables in template such as page title