Rename pseudo to username

users/admin.py

@@ -11,17 +11,6 @@ from .forms import UserChangeForm, UserCreationForm
 from .models import User, Right, Adhesion, ListRight, Clef, Request
 
 
-class UserAdmin(admin.ModelAdmin):
-    list_display = (
-        'name',
-        'surname',
-        'pseudo',
-        'email',
-        'is_active'
-    )
-    search_fields = ('name', 'surname', 'pseudo')
-
-
 class RequestAdmin(admin.ModelAdmin):
     list_display = ('user', 'type', 'created_at', 'expires_at')
 
@@ -50,10 +39,10 @@ class UserAdmin(VersionAdmin, BaseUserAdmin):
     # The fields to be used in displaying the User model.
     # These override the definitions on the base UserAdmin
     # that reference specific fields on auth.User.
-    list_display = ('pseudo', 'name', 'surname', 'email', 'is_admin')
+    list_display = ('username', 'name', 'surname', 'email', 'is_admin')
     list_filter = ()
     fieldsets = (
-        (None, {'fields': ('pseudo', 'password')}),
+        (None, {'fields': ('username', 'password')}),
         ('Personal info', {'fields': ('name', 'surname', 'email')}),
         ('Permissions', {'fields': ('is_admin',)}),
     )
@@ -62,11 +51,11 @@ class UserAdmin(VersionAdmin, BaseUserAdmin):
     add_fieldsets = (
         (None, {
             'classes': ('wide',),
-            'fields': ('pseudo', 'name', 'surname', 'email', 'is_admin', 'password1', 'password2')}
+            'fields': ('username', 'name', 'surname', 'email', 'is_admin', 'password1', 'password2')}
          ),
     )
-    search_fields = ('pseudo',)
-    ordering = ('pseudo',)
+    search_fields = ('username',)
+    ordering = ('username',)
     filter_horizontal = ()
 
 

users/forms.py

@@ -28,7 +28,7 @@ class UserCreationForm(forms.ModelForm):
 
     class Meta:
         model = User
-        fields = ('pseudo', 'name', 'surname', 'email')
+        fields = ('username', 'name', 'surname', 'email')
 
     def clean_password2(self):
         # Check that the two password entries match
@@ -57,7 +57,7 @@ class UserChangeForm(forms.ModelForm):
 
     class Meta:
         model = User
-        fields = ('pseudo', 'password', 'name', 'surname', 'email')
+        fields = ('username', 'password', 'name', 'surname', 'email')
 
     def __init__(self, *args, **kwargs):
         super(UserChangeForm, self).__init__(*args, **kwargs)
@@ -90,7 +90,7 @@ class BaseInfoForm(ModelForm):
         model = User
         fields = [
             'name',
-            'pseudo',
+            'username',
             'surname',
             'email',
             'telephone',
@@ -102,7 +102,7 @@ class InfoForm(BaseInfoForm):
     class Meta(BaseInfoForm.Meta):
         fields = [
             'name',
-            'pseudo',
+            'username',
             'surname',
             'email',
             'telephone',

users/migrations/0013_auto_20190802_2125.py

@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.22 on 2019-08-02 19:25
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('users', '0012_auto_20190802_2112'),
+    ]
+
+    operations = [
+        migrations.RenameField(
+            model_name='user',
+            old_name='pseudo',
+            new_name='username',
+        ),
+    ]

users/migrations/0014_auto_20190802_2126.py

@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.22 on 2019-08-02 19:26
+from __future__ import unicode_literals
+
+import django.contrib.auth.validators
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('users', '0013_auto_20190802_2125'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='user',
+            name='username',
+            field=models.CharField(error_messages={'unique': 'A user with that username already exists.'}, help_text='Required. 150 characters or fewer. Letters, digits and @/./+/-/_ only.', max_length=150, unique=True, validators=[django.contrib.auth.validators.UnicodeUsernameValidator()], verbose_name='username'),
+        ),
+    ]

users/models.py

@@ -6,8 +6,9 @@ import datetime
 import uuid
 
 from django.contrib.auth.models import AbstractBaseUser, BaseUserManager
+from django.contrib.auth.validators import ASCIIUsernameValidator, UnicodeUsernameValidator
 from django.db import models
-from django.utils import timezone
+from django.utils import six, timezone
 from django.utils.translation import gettext_lazy as _
 
 from med.settings import MAX_EMPRUNT, REQ_EXPIRE_HRS
@@ -25,7 +26,7 @@ class UserManager(BaseUserManager):
         email = self.normalize_email(email)
         username = self.model.normalize_username(username)
         user = self.model(
-            pseudo=username,
+            username=username,
             name=name,
             surname=surname,
             email=email,
@@ -37,22 +38,23 @@ class UserManager(BaseUserManager):
             user.make_admin()
         return user
 
-    def create_user(self, pseudo, name, surname, email, password=None):
+    def create_user(self, username, name, surname, email, password=None):
         """
-        Creates and saves a User with the given pseudo, name, surname, email,
+        Creates and saves a User with the given username, name, surname, email,
         and password.
         """
-        return self._create_user(pseudo, name, surname, email, password, False)
+        return self._create_user(username, name, surname, email, password, False)
 
-    def create_superuser(self, pseudo, name, surname, email, password):
+    def create_superuser(self, username, name, surname, email, password):
         """
-        Creates and saves a superuser with the given pseudo, name, surname,
+        Creates and saves a superuser with the given username, name, surname,
         email, and password.
         """
-        return self._create_user(pseudo, name, surname, email, password, True)
+        return self._create_user(username, name, surname, email, password, True)
 
 
 class User(AbstractBaseUser):
+    username_validator = UnicodeUsernameValidator() if six.PY3 else ASCIIUsernameValidator()
     PRETTY_NAME = "Utilisateurs"
 
     name = models.CharField(max_length=255)
@@ -61,8 +63,16 @@ class User(AbstractBaseUser):
     telephone = models.CharField(max_length=15, null=True, blank=True)
     adresse = models.CharField(max_length=255, null=True, blank=True)
     maxemprunt = models.IntegerField(default=MAX_EMPRUNT, help_text="Maximum d'emprunts autorisés")
-    pseudo = models.CharField(max_length=32, unique=True,
-                              help_text="Doit contenir uniquement des lettres, chiffres, ou tirets. ")
+    username = models.CharField(
+        _('username'),
+        max_length=150,
+        unique=True,
+        help_text=_('Required. 150 characters or fewer. Letters, digits and @/./+/-/_ only.'),
+        validators=[username_validator],
+        error_messages={
+            'unique': _("A user with that username already exists."),
+        },
+    )
     comment = models.CharField(help_text="Commentaire, promo", max_length=255, blank=True)
     is_staff = models.BooleanField(
         _('staff status'),
@@ -79,7 +89,7 @@ class User(AbstractBaseUser):
     )
     registered = models.DateTimeField(auto_now_add=True)
 
-    USERNAME_FIELD = 'pseudo'
+    USERNAME_FIELD = 'username'
     REQUIRED_FIELDS = ['name', 'surname', 'email']
 
     objects = UserManager()
@@ -125,7 +135,8 @@ class User(AbstractBaseUser):
 
     @property
     def is_adherent(self):
-        return self in Adhesion.objects.all().order_by('annee_debut').reverse().first().adherent.all()
+        last_adh_year = Adhesion.objects.all().order_by('annee_debut').reverse().first()
+        return last_adh_year and self in last_adh_year.adherent.all()
 
     def get_admin_right(self):
         admin, created = ListRight.objects.get_or_create(listright="admin")
@@ -146,7 +157,7 @@ class User(AbstractBaseUser):
         user_right.delete()
 
     def __str__(self):
-        return self.pseudo
+        return self.username
 
 
 class Request(models.Model):

users/templates/users/aff_users.html

@@ -42,7 +42,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
         <tr>
             <td>{{ user.name }}</td>
             <td>{{ user.surname }}</td>
-            <td>{{ user.pseudo }}</td>
+            <td>{{ user.username }}</td>
             <td>{{ user.email }}</td>
             <td>{{ user.maxemprunt }}</td>
             {% if user.is_adherent %}

users/templates/users/profil.html

@@ -65,7 +65,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
         </tr>
         <tr>
             <th>Pseudo</th>
-            <td>{{ user.pseudo }}</td>
+            <td>{{ user.username }}</td>
             <th>E-mail</th>
             <td>{{ user.email }}</td>
         </tr>

users/views.py

@@ -81,7 +81,7 @@ def new_user(request):
         req.save()
         reset_passwd_mail(req, request)
         messages.success(request,
-                         "L'utilisateur %s a été crée, un mail pour l'initialisation du mot de passe a été envoyé" % user.pseudo)
+                         "L'utilisateur %s a été crée, un mail pour l'initialisation du mot de passe a été envoyé" % user.username)
         return redirect("/users/profil/" + str(user.id))
     return form({'userform': user}, 'users/user.html', request)